Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure serviceMonitor condition for monitoring API #4667 #1005

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cesarokuti
Copy link

@cesarokuti cesarokuti commented Sep 21, 2023

Issue

Description of changes

Fixes
Description
Some installations we configure Karpenter before prometheus-operator and our argo-cd Waves broke and cannot continue the installation we implement the same structure as argocd helm-chart to check if the monitoring API is available.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant