-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 Batch Operations 2.0 Schema Fields to S3BatchJob/S3BatchJobTask #550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 26 26
Lines 1487 1487
=======================================
Hits 1090 1090
Misses 324 324
Partials 73 73 ☔ View full report in Codecov by Sentry. |
Since the new schema version removes a field, rather than being purely additive, let's do new structs with a |
@bmoffatt I've split it into a new struct |
I'd say leave the response struct as-is |
This PR adds support for the new S3 Batch Job 2.0 Invocation Schema by adding the
userArguments
field and thes3Bucket
key (instead ofs3BucketArn
) to the existingS3BatchJob
andS3BatchJobTask
structs. For more details see this blog post: https://aws.amazon.com/blogs/storage/automate-object-processing-in-amazon-s3-directory-buckets-with-s3-batch-operations-and-aws-lambda/I'm unsure if this should be a new struct specifically for 2.0 or just a small modification to the existing struct as implemented in this PR. Lambda Powertools for Python has implemented it as the same object/class for both schema versions but also has the benefit of Python's looser typing: aws-powertools/powertools-lambda-python#3572By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.