Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: greedy variable can be any value #1911

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: greedy variable can be any value #1911

merged 2 commits into from
Dec 20, 2024
+55 −16

Conversation

philasmar
Copy link
Contributor

Description of changes:

  • Previously, I hard coded the greedy variable as {proxy+}. In reality, the greedy variable can have any value and not "proxy" explicitly. This PR updates that behavior.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

normj
normj approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming you address @gcbeattyAWS comments.

@philasmar philasmar merged commit 77cd889 into feature/lambdatesttool-v2 Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcbeattyAWS gcbeattyAWS gcbeattyAWS approved these changes

@normj normj normj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philasmar @normj @gcbeattyAWS