Handle when Lambda events are sent unix epoch dates in milliseconds #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/). This PR updates the usage of `set-output` to `$GITHUB_OUTPUT` Instructions for envvar usage from GitHub docs: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
ashovlin
approved these changes
Apr 2, 2024
| @@ -12,6 +12,7 @@ namespace Amazon.Lambda.Serialization.Json | |||
| /// </summary> | |||
| internal class JsonNumberToDateTimeDataConverter : JsonConverter | |||
| { | |||
| private const long YEAR_5000_IN_SECONDS = 157753180800; | |||
There was a problem hiding this comment.
Got a little confused when checking the math. At first I assumed this was seconds-since-epoch, but appears to be since year 1. https://dotnetfiddle.net/0VesSV
Not a big deal functionally though, same principle applies. 👍
There was a problem hiding this comment.
Added a comment to make it clearer.
ashishdhingra
approved these changes
Apr 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#839
Description of changes:
When Kinesis streams are used to handle DynamoDB events they send the approximate date a unix epoch in milliseconds. When coming from a DynamoDB stream event they are seconds which is the normal format.
Since there isn't a way to detect the source of the event the serializers are updated to look to see if the
longin the event would be greater then the number of seconds for the year5000. If so then assume the value is in milliseconds. The other alternative I could have done is try to create theDateTimewith the millisecond epoch and if I got an out of range exception fallback to creating the DateTime from milliseconds but I wanted to avoid control flow by exceptions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.