Update Lambda PowerShell to target .NET 8 runtime #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
approved these changes
Feb 18, 2024
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1'"> | ||
| <PackageReference Include="Microsoft.PowerShell.SDK" Version="6.0.4" /> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net6.0'"> | ||
| <PackageReference Include="Microsoft.PowerShell.SDK" Version="7.2.1" /> |
There was a problem hiding this comment.
Just curious/don't need to see changes, but any reason for 7.2.1 over 7.2.18 (looks like the most recent .NET 6 release)?
There was a problem hiding this comment.
Updated to version 7.2.18.
afroz429
reviewed
Feb 19, 2024
| @@ -3,20 +3,20 @@ | |||
| <Import Project="..\..\..\buildtools\common.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFrameworks>net6.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Technically somebody could stick with the old major version of the module and have a "PowerShell Lambda .NET project" and update to this new major version of Amazon.Lambda.PowerShellHost. An unlikely scenario but since .NET 6 is still in support I'm not ready to rule it out.
afroz429
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In preparation for the upcoming .NET 8 release update the
AWSLambdaPSCoremodule for publishing PowerShell scripts to target .NET 8 and the upcoming .NET 8 Lambda runtime.This follows the pattern we have done for previous runtime releases. The module has a major version update to v4. Users that take the v4 major version update will deploy to .NET 8. If users want to stay with .NET 6 then they need to keep using the v3.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.