Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the JSON deserialization error in Cognito triggered lambda - Issue #1644 #1646

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

ankushjain358
Copy link
Contributor

Issue #1644

Issue #, if available:

Description of changes: Made the required properties nullable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashovlin
Copy link
Member

Hey @ankushjain358 - the change looks good, but could you add unit test that exercise null values? Reading #1644 (comment), I'm not too concerned about verifying correctness now, but would rather guard against future regressions. We've long mused about someday generating the event models as opposed to handwriting them, and wouldn't want to flip the nullability back accidentally if we do (and like @ashishdhingra commented in the issue, the documentation isn't always clear about nullability).

Also, if you do revisit the change, could you take this to 3.0.0? We'll handle the changelog as part of the release process.

@ankushjain358
Copy link
Contributor Author

@ashovlin - I have pushed the requested changes. Please take a look.

@normj normj changed the base branch from master to dev January 19, 2024 00:55
@normj normj merged commit 2fe078a into aws:dev Jan 19, 2024
2 of 3 checks passed
@normj
Copy link
Member

normj commented Jan 19, 2024

Thanks for the PR. Version 3.0.0 has just been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants