Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize --instance-type-archs values #529

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Normalize --instance-type-archs values #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions kubetest2/internal/deployers/eksapi/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,19 @@ func (m *nodeManager) createNodes(infra *Infrastructure, cluster *Cluster, opts
func (m *nodeManager) resolveInstanceTypes(opts *deployerOptions) (err error) {
instanceTypes := opts.InstanceTypes
if len(instanceTypes) == 0 {

if len(opts.InstanceTypeArchs) > 0 {
klog.Infof("choosing instance types based on architecture(s): %v", opts.InstanceTypeArchs)
for _, arch := range opts.InstanceTypeArchs {
instanceTypesForArch, ok := defaultInstanceTypesByEC2ArchitectureValues[ec2types.ArchitectureValues(arch)]
var ec2Arch ec2types.ArchitectureValues
switch arch {
case "x86_64", "amd64":
ec2Arch = ec2types.ArchitectureValuesX8664
case "aarch64", "arm64":
ec2Arch = ec2types.ArchitectureValuesArm64
default:
return fmt.Errorf("unknown architecture: '%s'", arch)
}
instanceTypesForArch, ok := defaultInstanceTypesByEC2ArchitectureValues[ec2Arch]
if !ok {
return fmt.Errorf("no default instance types known for architecture: '%s'", arch)
}
Expand Down
Loading