-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): runtimes nodejs-playwright-1.0 and python-selenium-4.1 #32517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32517 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5633 5633
Misses 1343 1343
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel strongly that this needs to be a feat so it shows up in our changelog. I will leave it to other maintainers to decide if we need unit/integ testing before they add any exemption labels.
[just kidding: i added them all because I'm not confident this will get picked up as ready to review without it]
@kaizencc Probably should add an integ test at least for Playwright, given this is the first version of it, even if it's still just a Node runtime |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
It definitely is, thanks for letting me know, I must have only checked for open issues 🤦 |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Could not find any in the backlog
Reason for this change
Update the CDK listed Synthetics runtimes to match the current availability, as well as add missing deprecated versions
Description of changes
Description of how you validated changes
I compared the current CDK versions to live SDK data, using the
synthetics:DescribeRuntimeVersions
API results. Deprecated versions were established using theDeprecationDate
field (none for this round of changes)Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license