Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): runtimes nodejs-playwright-1.0 and python-selenium-4.1 #32517

Closed

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Dec 13, 2024

Issue # (if applicable)

Could not find any in the backlog

Reason for this change

Update the CDK listed Synthetics runtimes to match the current availability, as well as add missing deprecated versions

Description of changes

  • Added new runtimes

Description of how you validated changes

I compared the current CDK versions to live SDK data, using the synthetics:DescribeRuntimeVersions API results. Deprecated versions were established using the DeprecationDate field (none for this round of changes)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2024 17:25
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (934c9dc) to head (ffc6603).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32517   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         107      107           
  Lines        7161     7161           
  Branches     1320     1320           
=======================================
  Hits         5633     5633           
  Misses       1343     1343           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (ø)

@kaizencc kaizencc changed the title chore(synthetics): update runtimes feat(synthetics): runtimes nodejs-playwright-1.0 and python-selenium-4.1 Dec 13, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel strongly that this needs to be a feat so it shows up in our changelog. I will leave it to other maintainers to decide if we need unit/integ testing before they add any exemption labels.

[just kidding: i added them all because I'm not confident this will get picked up as ready to review without it]

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 13, 2024
@nmussy
Copy link
Contributor Author

nmussy commented Dec 13, 2024

@kaizencc Probably should add an integ test at least for Playwright, given this is the first version of it, even if it's still just a Node runtime

@nmussy nmussy marked this pull request as draft December 13, 2024 17:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ffc6603
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@gracelu0
Copy link
Contributor

Hi @nmussy , I believe this is a duplicate of #32245. Could you help review and confirm?

@nmussy
Copy link
Contributor Author

nmussy commented Dec 14, 2024

It definitely is, thanks for letting me know, I must have only checked for open issues 🤦

@nmussy nmussy closed this Dec 14, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants