Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
kaizencc authored Dec 23, 2024
1 parent 6f15657 commit e57a05f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
3 changes: 1 addition & 2 deletions packages/@aws-cdk/toolkit/lib/cloud-assembly-source.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export interface CdkAppDirectoryProps {
}

export class CloudAssemblySource implements ICloudAssemblySource {

/**
* Use a directory containing an AWS CDK app as source.
* @param directory the directory of the AWS CDK app. Defaults to the current working directory.
Expand All @@ -50,7 +49,7 @@ export class CloudAssemblySource implements ICloudAssemblySource {
}

/**
* A CloudAssemblySource that is caching it's result once produced.
* A CloudAssemblySource that is caching its result once produced.
*
* Most Toolkit interactions should use a cached source.
* Not caching is relevant when the source changes frequently
Expand Down
16 changes: 8 additions & 8 deletions packages/@aws-cdk/toolkit/lib/io-host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ export interface IoRequest<T, U> extends IoMessage<T> {

export interface IIoHost {
/**
* Notifies the host of a message.
* The caller waits until the notification completes.
*/
* Notifies the host of a message.
* The caller waits until the notification completes.
*/
notify<T>(msg: IoMessage<T>): Promise<void>;

/**
* Notifies the host of a message that requires a response.
*
* If the host does not return a response the suggested
* default response from the input message will be used.
*/
* Notifies the host of a message that requires a response.
*
* If the host does not return a response the suggested
* default response from the input message will be used.
*/
requestResponse<T, U>(msg: IoRequest<T, U>): Promise<U | undefined>;
}
2 changes: 1 addition & 1 deletion packages/@aws-cdk/toolkit/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export enum StackSelectionStrategy {
/**
* Throws an exception if the app doesn't contain at least one stack.
*/
AtLeastOne = 'at-lest-one',
AtLeastOne = 'at-least-one',

/**
* Returns all stacks in the main (top level) assembly only.
Expand Down

0 comments on commit e57a05f

Please sign in to comment.