Limit /etc/pki directory appnet agent bind mount to iso regions #4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
sparrc-sc-pki-mount
branch
5 times, most recently
from
24a6b35 to
ee9dc5f
Compare
sparrc
force-pushed
the
sparrc-sc-pki-mount
branch
from
ee9dc5f to
d19bf9c
Compare
sparrc
changed the title
sparrc
commented
Dec 5, 2024
| @@ -161,6 +161,11 @@ func TestDependencyComplete(t *testing.T) { | |||
| // Container 'parent' depends on container 'dependency' to START. We ensure that the 'parent' container starts only | |||
| // after the 'dependency' container has started. | |||
| func TestDependencyStart(t *testing.T) { | |||
| // Skip these tests on WS 2016 until the failures are root-caused. | |||
There was a problem hiding this comment.
Unrelated to this change, but the rest of this tests here are already skipped on WS 2016, adding this one because it is failing intermittently.
tinnywang
approved these changes
Dec 5, 2024
danehlim
reviewed
Dec 5, 2024
danehlim
reviewed
Dec 5, 2024
danehlim
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #4437
Limit the /etc/pki directory mount in the appnet agent container to isolated regions.
This ensures that commercial/us-gov/cn partitions are unaffected by this changed directory mount to limit blast radius.
A future PR may expand this change to more partitions as needed and tested.
Testing
New tests cover the changes: yes, unit tests
Description for the changelog
NA
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.