Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename duplicate time field to be more descriptive and unique #4444

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sjpalf
Copy link

@sjpalf sjpalf commented Nov 28, 2024

Summary

Rename the log field used to show when an essential container was stopped, from time to ExecutionStoppedAt.
When logging that an essential container is stopped, we log the time that the container was stopped at. As all logs contain the fields level, time and msg, we end up with a duplicated time field, which some log processors are unable to handle - here is an example log:

{"level":"info","time":"2024-11-27T12:50:26Z","msg":"Essential container stopped; recording task stopped time","container":"ecs-appmesh-task-helper","task":"ad289555e6d74bf696db794907dcf1d4","time":"2024-11-27 12:50:26.023783669 +0000 UTC m=+89089.452265064"}

Implementation details

Renamed the extra logging field from time to ExecutionStoppedAt

Testing

Automated tests

New tests cover the changes: no

Description for the changelog

Enhancement: Renamed duplicated time field when logging container stopped events

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?
No

Does this PR include the addition of new environment variables in the README?
No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sjpalf sjpalf marked this pull request as ready for review November 28, 2024 16:50
@sjpalf sjpalf requested a review from a team as a code owner November 28, 2024 16:50
agent/api/task/task.go Show resolved Hide resolved
@danehlim
Copy link
Contributor

danehlim commented Dec 2, 2024

Hi @sjpalf, thank you for opening this pull request! I have added a comment to clarify and request some modification to the changes.

@sjpalf sjpalf requested a review from danehlim December 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants