Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include full Dockerfile for FSDP example #503

Closed
wants to merge 1 commit into from
Closed

Conversation

sean-smith
Copy link
Contributor

This fixes #491

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mnuyens
Copy link
Contributor

mnuyens commented Nov 22, 2024

@sean-smith This change will make it so that the example can only be executed on hosts with cuda installed because GDRCopy fails if you don't. This will render it unuseable on many hosts that currently run the example.

@mnuyens
Copy link
Contributor

mnuyens commented Nov 22, 2024

@sean-smith if you update the Dockerfile to pin a few version the example works again

RUN pip install torchvision torchaudio transformers==4.46.1 datasets fsspec==2023.9.2 python-etcd numpy==1.*
RUN pip install torch==2.5.1+cu121 --index-url https://download.pytorch.org/whl/cu121

@sean-smith sean-smith closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSDP EKS Example failing with: module 'torch.library' has no attribute 'register_fake'
2 participants