Added authentication with API key and log added for generating credential failure #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: unit test cases added for API key auth fix: Log added for generating credentials failure refactor: CryptoUtils.kt and AwsAuthorizationHeaderHelper.kt functions changed to open from internal ALS-1862
# Conflicts: # README.md
ALS-1862 Authentication with API key added
README.md
Outdated
Comment on lines
37
to
38
| // Create a credentail provider using Identity Pool Id with AuthHelper | ||
| private fun exampleCognitoLogin() { | ||
| private suspend fun exampleCognitoLogin() { |
There was a problem hiding this comment.
Nit: "credentail" -> "credential"
README.md
Outdated
Comment on lines
46
to
47
| // Create a credentail provider using custom credential provider with AuthHelper | ||
| private fun exampleCustomCredentialLogin() { | ||
| private suspend fun exampleCustomCredentialLogin() { |
README.md
Outdated
|
|
||
| OR | ||
|
|
||
| // Create a credentail provider using Api key with AuthHelper |
README.md
Outdated
| private suspend fun exampleApiKeyLogin() { | ||
| var authHelper = AuthHelper(applicationContext) | ||
| var locationCredentialsProvider : LocationCredentialsProvider = authHelper.authenticateWithApiKey("MY-API-KEY", "MY-AWS-REGION") | ||
| var locationClient = locationCredentialsProvider.getLocationClient() |
There was a problem hiding this comment.
should this be locationCredentialsProvider?.getLocationClient()?
| credentials | ||
| ) | ||
| val credentials = cognitoIdentityClient?.getCredentialsForIdentity(GetCredentialsForIdentityRequest { this.identityId = identityId }) | ||
| ?.credentials ?: throw Exception("Failed to get credentials") |
There was a problem hiding this comment.
Nit: "Failed to get credentials" (one space between 'get' and 'credentials')
Comment on lines
360
to
361
| if ((method == "custom" || method == "apiKey") && customCredentials != null) { | ||
| return customCredentials |
There was a problem hiding this comment.
Should this return empty credentials instead of customCredentials for apiKey?
| @@ -10,7 +10,7 @@ import software.amazon.location.auth.utils.Constants.SIGNING_ALGORITHM | |||
| /** | |||
| * Sign the request with the aws authorization header | |||
| */ | |||
| internal fun Request.awsAuthorizationHeader( | |||
| fun Request.awsAuthorizationHeader( | |||
There was a problem hiding this comment.
Why did internal get removed off of these?
There was a problem hiding this comment.
I thought it would be helpful for our users to access that method but reverted back due to security concerns.
Comment on lines
12
to
14
| const val HASHING_ALGORITHM = "SHA-256" | ||
| const val MAC_ALGORITHM = "HmacSHA256" | ||
| const val ENCODED_CHARACTER_REGEX = "%[0-9A-Fa-f]{2}" |
There was a problem hiding this comment.
Why did internal get removed from this file too?
fix: Api key get credential returns empty credential fix fix: CryptoUtils.kt and AwsAuthorizationHeaderHelper.kt files method revert back to internal ALS-1862
neelmurt
approved these changes
Sep 20, 2024
mbalfour-amzn
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
feat: authentication with API key added
feat: unit test cases added for API key auth
fix: Log added for generating credentials failure
refactor:
CryptoUtils.ktandAwsAuthorizationHeaderHelper.ktfunctions changed to open from internalBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.