Remove cloud-seeder.xml from /software #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that in the review it wasn't catched that the was a XML file instead of a yaml file. The awesome-selfhosted-bot somehow still was able to create the [correct yaml file](https://github.com/awesome-selfhosted/awesome-selfhosted-data/blob/master/software/cloud-seeder.yml) from it
nodiscc
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Thank you.
Processor/exporter bug filed at nodiscc/hecat#139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in the review, it wasn’t caught that it was an XML file instead of a YAML file.
Interestingly, the awesome-selfhosted-bot somehow still managed to create the correct YAML file from it. (Though I’m curious how the script managed to completely ignore the wrong file extension! O_o)