Manually pack initialValidators for subnetConversion ID hash-preimage #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
geoff-vball
approved these changes
Sep 19, 2024
| pure | ||
| returns (bytes memory) | ||
| { | ||
| bytes memory res = new bytes(92 + subnetConversionData.initialValidators.length * 88); |
There was a problem hiding this comment.
From the comment above, it wasn't immediately clear to me why the constant was 92 here rather than 72. Mind adding a comment explaining the address is known to be 20 bytes long?
| } | ||
| // Pack the address | ||
| bytes20 addrBytes = bytes20(subnetConversionData.validatorManagerAddress); | ||
| for (uint256 i = 0; i < 20; i++) { |
There was a problem hiding this comment.
Nit: Lets use pre-increment like each of the other loops here.
| } | ||
|
|
||
| return res; | ||
| return abi.encodePacked(CODEC_ID, SUBNET_CONVERSION_MESSAGE_TYPE_ID, subnetConversionID); |
There was a problem hiding this comment.
While we're here, would you mind removing the TODO from line 46 above?
michaelkaplan13
approved these changes
Sep 20, 2024
bernard-avalabs
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Addresses #559 partially
How this works
How this was tested
Existing CI
How is this documented