added SunFounder actuator #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocGarbanzo
requested changes
Jun 25, 2021
donkeycar/parts/actuator.py
Outdated
| self.bw.speed = speed | ||
| elif speed < 0: | ||
| self.bw.backward() | ||
| self.bw.speed = speed * -1 |
There was a problem hiding this comment.
- speed avoids an unnecessary multiplication.
donkeycar/parts/actuator.py
Outdated
| def __init__(self): | ||
| import picar | ||
| from picar import back_wheels | ||
| print('Set up back_wheels') |
There was a problem hiding this comment.
We moved from print -> logging.
|
Hi @blaughlin - your code can't be merged, you have to rebase first. |
changed print to logging
blaughlin
force-pushed
the
SunFounderActuator
branch
from
3d9c8d7 to
40ab72b
Compare
DocGarbanzo
requested changes
Sep 3, 2021
| logger.info('Set up back_wheels') | ||
| picar.setup() | ||
| # place path to your car's config file below | ||
| db_file = "/home/pi/SunFounder_PiCar-V/remote_control/remote_control/driver/config" |
There was a problem hiding this comment.
This should be passed as an argument, and then we should have two config parameters in cfg_complete.py:
SUNFOUNDER = False
SUNFOUNDER_RC_CFG_PATH = "/home/pi/SunFounder_PiCar-V/remote_control/remote_control/driver/config"Add an entry in complete.py which does what you wrote in the comment above, i.e. change the throttle controller to your new part. Then it should work for the SunFounder car without tweaking any code, just an update of the myconfig.py file.
You should probably also write a comment in the class how to install the picar package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added actuator for SunFounder car kit. https://youtu.be/lvZDpLVAIQY