Accept a string or int in the gateway HTTP server #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
approved these changes
Dec 24, 2024
nazar-pc
reviewed
Dec 24, 2024
| let v: serde_json::Value = Deserialize::deserialize(deserializer)?; | ||
|
|
||
| match v { | ||
| Value::String(s) => s.parse::<u32>().map_err(serde::de::Error::custom), |
There was a problem hiding this comment.
I'd also print a warning here that it'll stop working in the next release.
@clostao are you happy to just make a breaking change here? It would be simpler for us. If we did it that way, next time you upgraded the gateway, you'd also need to upgrade to a version of the indexer which sent block numbers as integers (rather than block number strings). |
|
No problem with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the gateway accept a block number as a string or int from the HTTP server.
This is the first part of ticket #3323.
Once this PR merges, the HTTP server can start providing integers. When that is deployed, we can remove the string code and close #3323.
Code contributor checklist: