-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/components: add ability to create organization and subsidiary in FormFieldSelectTable #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maceksimon
force-pushed
the
feature/create-organization
branch
from
December 25, 2024 08:07
6147ef6
to
ea3f9f7
Compare
…prepeding new organization option into all options
maceksimon
added a commit
to maceksimon/ride-to-work-by-bike-frontend
that referenced
this pull request
Dec 25, 2024
…FormFieldSelectTable (auto-mat#804) * create organization * create organization + subsidiary * remove outdated comment * add test for creating organization in SelectTable * remove only * organization and subsidiary creation * update loading subsidiaries via store and post-creation update * do not persist subsidiaries * add comments * update docs and remove unrelated test * update onChangeOption handler * docs update * add docs * remove unused fixture * fix FormFieldCompanyAddress test (simulate onMounted hook) * src/components/form: fix logger info/debug message text * src/components/form: refactor onCreateOption() evt handler func with prepeding new organization option into all options * src/components/form: add logger debug messages * src/components/form: fix position of logger info message * src/components/form: add logger debug messages --------- Co-authored-by: Šimon Macek <[email protected]> Co-authored-by: Tomas Zigo <[email protected]>
tmszi
added a commit
that referenced
this pull request
Dec 26, 2024
…ble component (#800) * add team members to SelectTable * update team icon color * remove duplicate test * fix e2e test register_challenge * src/components: add ability to create organization and subsidiary in FormFieldSelectTable (#804) * create organization * create organization + subsidiary * remove outdated comment * add test for creating organization in SelectTable * remove only * organization and subsidiary creation * update loading subsidiaries via store and post-creation update * do not persist subsidiaries * add comments * update docs and remove unrelated test * update onChangeOption handler * docs update * add docs * remove unused fixture * fix FormFieldCompanyAddress test (simulate onMounted hook) * src/components/form: fix logger info/debug message text * src/components/form: refactor onCreateOption() evt handler func with prepeding new organization option into all options * src/components/form: add logger debug messages * src/components/form: fix position of logger info message * src/components/form: add logger debug messages --------- Co-authored-by: Šimon Macek <[email protected]> Co-authored-by: Tomas Zigo <[email protected]> * add team members to SelectTable * update team icon color * fix resetting the model value in component tests * use campaign max members for team max generation * Remove unnecessary defaultMaxTeamMembers global app config var Max team members value is readed from the REST API URL this_campaign/ endpoint. --------- Co-authored-by: Šimon Macek <[email protected]> Co-authored-by: Tomas Zigo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to create
organization
andsubsidiary
inFormFieldSelectTable
createOrganization
andcreateSubsidiary
API functions inFormFieldSelectTable
.subsidiary
options (reloading afterorganizationId
change and modifying after subsidiary create), save them inregisterChallenge
store.waitForOrganizationPostApi
(intercept is already defined in/support/commonTests.ts
) and for filling in organization form.FormSelectOrganization.cy.js
: intercept organizations and subsidiaries requests in existing tests to avoid error messages.