Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/components: show team size and members count in FormFieldSelectTable component #800

Merged
merged 10 commits into from
Dec 26, 2024

Conversation

maceksimon
Copy link
Contributor

Show team size and members count in FormFieldSelectTable component.

  • In composable useApiGetTeams, add members (source API) and maxMembers (source config) fields.
  • Update template to show colored icons and members count for each team.
  • Update test fixtures, to test option with full team.
  • Add component test for correct displaying of team info.

@tmszi tmszi added the enhancement New feature or request label Dec 21, 2024
@tmszi
Copy link
Member

tmszi commented Dec 21, 2024

Could @maceksimon resolve conflicts please?

@maceksimon maceksimon force-pushed the feature/display-team-members branch from 5813825 to f226623 Compare December 23, 2024 08:30
@maceksimon
Copy link
Contributor Author

Could @maceksimon resolve conflicts please?

These have been resolved.

@tmszi
Copy link
Member

tmszi commented Dec 25, 2024

Could @maceksimon resolve conflicts again, and refactor code to use max. team memebers value from the store var (merged PR #801) please?

Šimon Macek and others added 8 commits December 25, 2024 10:11
…FormFieldSelectTable (auto-mat#804)

* create organization

* create organization + subsidiary

* remove outdated comment

* add test for creating organization in SelectTable

* remove only

* organization and subsidiary creation

* update loading subsidiaries via store and post-creation update

* do not persist subsidiaries

* add comments

* update docs and remove unrelated test

* update onChangeOption handler

* docs update

* add docs

* remove unused fixture

* fix FormFieldCompanyAddress test (simulate onMounted hook)

* src/components/form: fix logger info/debug message text

* src/components/form: refactor onCreateOption() evt handler func with prepeding new organization option into all options

* src/components/form: add logger debug messages

* src/components/form: fix position of logger info message

* src/components/form: add logger debug messages

---------

Co-authored-by: Šimon Macek <[email protected]>
Co-authored-by: Tomas Zigo <[email protected]>
@maceksimon maceksimon force-pushed the feature/display-team-members branch from f226623 to d683840 Compare December 25, 2024 09:19
@maceksimon
Copy link
Contributor Author

Could @maceksimon resolve conflicts again, and refactor code to use max. team memebers value from the store var (merged PR #801) please?

Updated (I left the config variable as a default option in case the store var is not available).

Max team members value is readed from the REST API URL this_campaign/
endpoint.
@tmszi tmszi merged commit da8c2b0 into auto-mat:main Dec 26, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants