Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audqt: Parse font family names containing digits correctly #1488

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

radioactiveman
Copy link
Member

"PxPlus ToshibaSat 9x16 Bold 8" from the Oldschool PC Font Pack is such an example.
To parse the font family correctly, we need to check if all characters for the font size are digits.

Both str_to_int() and atoi() do not support this.
Use strtol() instead and check endptr accordingly.

Closes: #1483

…udacious-media-player#1483

"PxPlus ToshibaSat 9x16 Bold 8" from the Oldschool PC Font Pack
is such an example. To parse the font family correctly, we need
to check if all characters for the font size are digits.

Both str_to_int() and atoi() do not support this.
Use strtol() instead and check "endptr" accordingly.
@jlindgren90
Copy link
Member

An elegant fix. Thanks!

@jlindgren90 jlindgren90 merged commit dff5092 into audacious-media-player:master Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winamp Classic interface cannot use certain TrueType fonts
2 participants