This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
add a tooltip to the status bar item #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2017
damieng
reviewed
Apr 19, 2017
lib/status-bar-item.js
Outdated
| Mixed: 'mixed', | ||
| LF: 'LF (Unix)', | ||
| CRLF: 'CRLF (Windows)', | ||
| CR: 'CR (old Macintosh)' |
There was a problem hiding this comment.
can we changed "old Macintosh" to "Classic MacOS" ? That seems to be the most accurate way of describing Mac OS 1-9 given articles like https://en.wikipedia.org/wiki/Classic_Mac_OS
There was a problem hiding this comment.
Agreed, thanks! That's more pleasant.
7 tasks
1 task
|
We probably shouldn't have merged this one without adding tests. I can see how it seemed trivial, but the tooltip's text didn't update when the user switched the line endings. See #48 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This PR adds a tooltip to the status bar item:
Alternate Designs
No alternate designs were considered.
Benefits
Now even inexpert users should be able to understand what "LF" in the status bar means.
Possible Drawbacks
More code.
Applicable Issues
Should fix #14
Inspired by atom/encoding-selector#28 and atom/encoding-selector#45