Fetch --find-links indexes in parallel
#934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
performance
charliermarsh
force-pushed
the
charlie/parallel
branch
5 times, most recently
from
7c2630e to
ee6be7b
Compare
charliermarsh
force-pushed
the
charlie/parallel
branch
from
ee6be7b to
f0895a5
Compare
konstin
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes a TODO.
Test Plan
Tested manually with:
cargo run -p puffin-cli -- \ pip compile requirements.in -n \ --find-links 'https://download.pytorch.org/whl/torch_stable.html' \ --find-links 'https://storage.googleapis.com/jax-releases/jax_cuda_releases.html' \ --verboseAnd inspecting the logs to ensure that the two requests were kicked off concrurently.