Share a single Index across resolutions
#906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/share
branch
from
361fef9 to
e1a5143
Compare
charliermarsh
added
the
internal
zanieb
approved these changes
Jan 13, 2024
konstin
approved these changes
Jan 14, 2024
charliermarsh
force-pushed
the
charlie/index
branch
3 times, most recently
from
dbb7696 to
8e7fbea
Compare
charliermarsh
force-pushed
the
charlie/share
branch
from
e1a5143 to
df806fa
Compare
charliermarsh
force-pushed
the
charlie/share
branch
from
df806fa to
f18b534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses a single
Indexthat's shared between the top-level resolver and any sub-resolutions happen in the course of that top-level resolution (namely, to resolve build dependencies for any source distributions).In theory it's an optimization, since (e.g.) if we have two packages that both need the
flit-corebuild system, and we attempt to build them both at once, we'll only fetch its metadata once, and share it across the two resolutions. In practice, I haven't been able to get this to show up in benchmarks. I suspect you'd need a lot of source distributions for it to matter... Though it may still be worth doing, it strikes me as a cleaner design.Closes #200.
Closes #541.