feat: bump actions/{download,upload}-artifact #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github seems to be having a bad day, and I can't re-run the 1 that failed due to Github hiccups 😅 Can someone with permissions re-run |
|
Awesome, thank you! |
|
I know @MichaReiser wanted some input on astral-sh/ruff#10105 so I'm gonna wait until that gets merged, then merge this one to follow. |
|
Sounds good, wanted to make sure releases could continue since I think they're blocked due to the earlier cargo dist update in 5a50a75 and this PR fixes that. Although we can unblock releases by reverting that commit too. |
|
Ooh thank you, I didn't realize that! |
charliermarsh
approved these changes
Feb 26, 2024
|
Sorry, i also missed that cargo-dist change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1943
Makes sure
build-binariesandpublish-pypiworkflows are compatible withactions/{download,upload}-artifact@v4. In nature, this PR is very similar to the changes in astral-sh/ruff#10105. This PR also updates cargo-dist.Test Plan
I ran a small non-dry-run smoke test on my own fork CI with only linux builds (for speed) and those jobs seem to work at a glance.