-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop referring to early ruff versions #14862
Conversation
docs/formatter.md
Outdated
@@ -23,7 +21,7 @@ and instead exit with a non-zero status code upon detecting any unformatted file | |||
For the full list of supported options, run `ruff format --help`. | |||
|
|||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this shouldn't be a note any more, should it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we can remove the entire note here
docs/linter.md
Outdated
@@ -20,7 +20,7 @@ $ ruff check path/to/code/ # Lint all files in `path/to/code` (and any subdir | |||
For the full list of supported options, run `ruff check --help`. | |||
|
|||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just removed the notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This makes sense to me. I did a quick check and 0.1.3 is the version with the most downloads in the last 30 days (~90k) that is impacted by this documentation change. All other <=0.1.7
versions have fewer than 50k downloads in the last 30 days.
# Ruff version. | ||
rev: v0.1.4 | ||
rev: v0.8.2 | ||
hooks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this file to
Lines 106 to 113 in 3d9ac53
version_files = [ | |
"README.md", | |
"docs/integrations.md", | |
"crates/ruff/Cargo.toml", | |
"crates/ruff_linter/Cargo.toml", | |
"crates/ruff_wasm/Cargo.toml", | |
"scripts/benchmarks/pyproject.toml", | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added docs/tutorial.md
.
Referring to old versions has become more distracting than useful.
df0eba3
to
a2cd270
Compare
|
* main: [`airflow`] Add fix to remove deprecated keyword arguments (`AIR302`) (#14887) Improve mdtests style (#14884) Reference `suppress-dummy-regex-options` in documentation of rules supporting it (#14888) [`flake8-bugbear`] `itertools.batched()` without explicit `strict` (`B911`) (#14408) [`ruff`] Mark autofix for `RUF052` as always unsafe (#14824) [red-knot] Improve type inference for except handlers (#14838) More typos found by codespell (#14880) [red-knot] move standalone expression_ty to TypeInferenceBuilder::file_expression_ty (#14879) [`ruff`] Do not simplify `round()` calls (`RUF046`) (#14832) Stop referring to early ruff versions (#14862) Fix a typo in `class.rs` (#14877) [`flake8-pyi`] Also remove `self` and `cls`'s annotation (`PYI034`) (#14801) [`pyupgrade`] Remove unreachable code in `UP015` implementation (#14871) [`flake8-bugbear`] Skip `B028` if `warnings.warn` is called with `*args` or `**kwargs` (#14870)
Summary
Referring to old versions has become more distracting than useful.
Test Plan
—