Drop netstandard for $(NetCoreTFM) #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this change led to a bunch of runtime package dependency changes (which will likely run afoul of #728) and several dependency conflicts (which are addressed via #747). Hence I've created this PR as a draft until the other can be merged first, and it will also need someone to populate the package feed for the new runtime packages. |
Netstandard gives compatibility benefits for libraries to be used against netfx or netcore frameworks. However, for libman, all of our projects that run on netcore already target that framework directly. This change modifies the existing multitargeted projects to target netcore directly instead of netstandard. This will allow future changes to use conditional compilation to leverage newer APIs in netcore that do not exist in the netstandard API surface. The only breaking change here is that the Build project now uses .NET 8 for the build task. This means consumers of that package who are not using .NET Framework will need to have a compatible version of the SDK; however, this aligns with the prior change in the CLI tool to require .NET 8 as well.
phil-allen-msft
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netstandard gives compatibility benefits for libraries to be used against netfx or netcore frameworks. However, for libman, all of our projects that run on netcore already target that framework directly.
This change modifies the existing multitargeted projects to target netcore directly instead of netstandard. This will allow future changes to use conditional compilation to leverage newer APIs in netcore that do not exist in the netstandard API surface.
The only breaking change here is that the Build project now uses .NET 8 for the build task. This means consumers of that package who are not using .NET Framework will need to have a compatible version of the SDK; however, this aligns with the prior change in the CLI tool to require .NET 8 as well.