forked from whitecube/nova-flexible-content
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nova version upgrade #1
Open
parth-ka-patel
wants to merge
154
commits into
master
Choose a base branch
from
feature/nova-version-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure it doesn't creep out of the window at the top, we recalculate its height client-side based on its y position. This ensures the dropdown is only ever as high as the top of the screen. Scrollbars (thanks to overflow-y: auto) will take care of the rest. This fixes cases where the button is high on the screen, causing the first options in the dropdown to be unselectable.
`app()->runningInConsole()` solves the problem with unit tests, so we don't need this hardcoded environment check any longer. Additionally, if we want to use `testing` environment instead of `local` for some reason ( to check something while developing ), this env check will cause errors on nova pages with flexible fields.
…ue when use dependent multiselect options
Fix some type issues detected by Psalm
…rn/webpack-5.76.1 Bump webpack from 5.75.0 to 5.76.1
Add Psalm to project and CI
…rn/json5-1.0.2 Bump json5 from 1.0.1 to 1.0.2
…rn/engine.io-6.2.1 Bump engine.io from 6.2.0 to 6.2.1
Fixing file validation rules
Fix forceFill issue
Add forceFill method to Layout class
Add missing imports
whitecube#469 broke existing layouts. This PR rectifies that.
Fix existing layouts breaking as of 1.0.9
…ue when use dependent multiselect options
…n-upgrade # Conflicts: # composer.json # dist/js/field.js # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take latest pull from upstream branch and update vue 3 and commit all changes