Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline modifier in handleErrorWith function #3550

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add inline modifier in handleErrorWith function #3550

merged 2 commits into from
Dec 17, 2024

Conversation

PavlosTze
Copy link
Contributor

The PR fixing issue #3547.

hoc081098
hoc081098 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

hoc081098
hoc081098 reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run ./gradlew apiDump to update public api files (.api)

@PavlosTze
Copy link
Contributor Author

You should run ./gradlew apiDump to update public api files (.api)

Oh, thanks. I was looking at Requirements to change an existing feature and it didn't mention this.

Fixed!

@PavlosTze PavlosTze requested a review from hoc081098 December 16, 2024 12:47
@serras serras merged commit 27330d7 into arrow-kt:main Dec 17, 2024
10 checks passed
@serras serras mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras serras approved these changes

@hoc081098 hoc081098 Awaiting requested review from hoc081098

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavlosTze @serras @hoc081098