-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow Fx DSL #3443
Draft
nomisRev
wants to merge
9
commits into
main
Choose a base branch
from
scoped
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+872
−206
Draft
Arrow Fx DSL #3443
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7478762
Generic Scope DSL
nomisRev ba3f283
apiDump spotlessApply
nomisRev 8b4829f
Rename to finally DSL
nomisRev 34d1eae
Auto-update API files
nomisRev 1abb7e6
Split Fx DSL
nomisRev a244b4f
Merge branch 'scoped' of github.com:arrow-kt/arrow into scoped
nomisRev 0480b20
Merge remote-tracking branch 'origin/main' into scoped
nomisRev 1fbd2a8
WIP, DSL module
nomisRev 796e30a
Arrow Fx DSL module
nomisRev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
public abstract interface class arrow/AutoCloseScope { | ||
public abstract fun autoClose (Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public abstract fun autoClose (Lkotlin/jvm/functions/Function1;)V | ||
public abstract fun install (Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/AutoCloseScope$DefaultImpls { | ||
public static fun autoClose (Larrow/AutoCloseScope;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public static fun install (Larrow/AutoCloseScope;Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/AutoCloseScopeKt { | ||
public static final fun autoCloseScope (Lkotlin/jvm/functions/Function1;)Ljava/lang/Object; | ||
} | ||
|
||
public final class arrow/AutoCloseableExtensionsKt { | ||
public static final fun install (Larrow/AutoCloseScope;Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/CoroutineScopeKt { | ||
public static final fun coroutineScope (Larrow/Scope;Lkotlin/coroutines/CoroutineContext;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | ||
} | ||
|
||
public final class arrow/DefaultAutoCloseScope : arrow/AutoCloseScope { | ||
public fun <init> ()V | ||
public fun autoClose (Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public fun autoClose (Lkotlin/jvm/functions/Function1;)V | ||
public final fun close (Ljava/lang/Throwable;)Ljava/lang/Void; | ||
public fun install (Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/SagaKt { | ||
public static final fun saga (Larrow/Scope;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function3;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | ||
} | ||
|
||
public abstract interface class arrow/Scope : arrow/AutoCloseScope { | ||
public abstract fun autoClose (Lkotlin/jvm/functions/Function1;)V | ||
public abstract fun finalise (Lkotlin/jvm/functions/Function2;)V | ||
} | ||
|
||
public final class arrow/Scope$DefaultImpls { | ||
public static fun autoClose (Larrow/Scope;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public static fun install (Larrow/Scope;Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/ScopeKt { | ||
public static final fun scoped (Lkotlin/jvm/functions/Function1;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | ||
} | ||
|
||
public final class arrow/ThrowIfFatalKt { | ||
public static final fun throwIfFatal (Ljava/lang/Throwable;)Ljava/lang/Throwable; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Klib ABI Dump | ||
// Targets: [iosArm64, iosSimulatorArm64, iosX64, js, linuxArm64, linuxX64, macosArm64, macosX64, mingwX64, tvosArm64, tvosSimulatorArm64, tvosX64, watchosArm32, watchosArm64, watchosSimulatorArm64, watchosX64] | ||
// Rendering settings: | ||
// - Signature version: 2 | ||
// - Show manifest properties: true | ||
// - Show declarations: true | ||
|
||
// Library unique name: <io.arrow-kt:arrow-scope> | ||
abstract interface arrow/AutoCloseScope { // arrow/AutoCloseScope|null[0] | ||
abstract fun autoClose(kotlin/Function1<kotlin/Throwable?, kotlin/Unit>) // arrow/AutoCloseScope.autoClose|autoClose(kotlin.Function1<kotlin.Throwable?,kotlin.Unit>){}[0] | ||
open fun <#A1: kotlin/Any?> autoClose(kotlin/Function0<#A1>, kotlin/Function2<#A1, kotlin/Throwable?, kotlin/Unit>): #A1 // arrow/AutoCloseScope.autoClose|autoClose(kotlin.Function0<0:0>;kotlin.Function2<0:0,kotlin.Throwable?,kotlin.Unit>){0§<kotlin.Any?>}[0] | ||
open fun <#A1: kotlin/AutoCloseable> install(#A1): #A1 // arrow/AutoCloseScope.install|install(0:0){0§<kotlin.AutoCloseable>}[0] | ||
} | ||
abstract interface arrow/Scope : arrow/AutoCloseScope { // arrow/Scope|null[0] | ||
abstract fun autoClose(kotlin/Function1<kotlin/Throwable?, kotlin/Unit>) // arrow/Scope.autoClose|autoClose(kotlin.Function1<kotlin.Throwable?,kotlin.Unit>){}[0] | ||
abstract fun finalise(kotlin.coroutines/SuspendFunction1<kotlin/Throwable?, kotlin/Unit>) // arrow/Scope.finalise|finalise(kotlin.coroutines.SuspendFunction1<kotlin.Throwable?,kotlin.Unit>){}[0] | ||
} | ||
final class arrow/DefaultAutoCloseScope : arrow/AutoCloseScope { // arrow/DefaultAutoCloseScope|null[0] | ||
constructor <init>() // arrow/DefaultAutoCloseScope.<init>|<init>(){}[0] | ||
final fun autoClose(kotlin/Function1<kotlin/Throwable?, kotlin/Unit>) // arrow/DefaultAutoCloseScope.autoClose|autoClose(kotlin.Function1<kotlin.Throwable?,kotlin.Unit>){}[0] | ||
final fun close(kotlin/Throwable?): kotlin/Nothing? // arrow/DefaultAutoCloseScope.close|close(kotlin.Throwable?){}[0] | ||
} | ||
final fun (kotlin/Throwable).arrow/throwIfFatal(): kotlin/Throwable // arrow/throwIfFatal|[email protected](){}[0] | ||
final inline fun <#A: kotlin/Any?> arrow/autoCloseScope(kotlin/Function1<arrow/AutoCloseScope, #A>): #A // arrow/autoCloseScope|autoCloseScope(kotlin.Function1<arrow.AutoCloseScope,0:0>){0§<kotlin.Any?>}[0] | ||
final suspend fun (arrow/Scope).arrow/coroutineScope(kotlin.coroutines/CoroutineContext): kotlinx.coroutines/CoroutineScope // arrow/coroutineScope|[email protected](kotlin.coroutines.CoroutineContext){}[0] | ||
final suspend fun <#A: kotlin/Any?> (arrow/Scope).arrow/saga(kotlin.coroutines/SuspendFunction0<#A>, kotlin.coroutines/SuspendFunction2<#A, kotlin/Throwable?, kotlin/Unit>): #A // arrow/saga|[email protected](kotlin.coroutines.SuspendFunction0<0:0>;kotlin.coroutines.SuspendFunction2<0:0,kotlin.Throwable?,kotlin.Unit>){0§<kotlin.Any?>}[0] | ||
final suspend fun <#A: kotlin/Any?> arrow/scoped(kotlin/Function1<arrow/Scope, #A>): #A // arrow/scoped|scoped(kotlin.Function1<arrow.Scope,0:0>){0§<kotlin.Any?>}[0] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 0 additions & 56 deletions
56
arrow-libs/core/arrow-continuations/api/arrow-continuations.api
This file was deleted.
Oops, something went wrong.
31 changes: 0 additions & 31 deletions
31
...s/core/arrow-continuations/src/wasmJsMain/kotlin/arrow/continuations/generic/AtomicRef.kt
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
...arrow-continuations/src/wasmJsMain/kotlin/arrow/continuations/generic/ControlThrowable.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 0 additions & 72 deletions
72
...s/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/await/AwaitAllScope.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
public abstract interface class arrow/AutoCloseScope { | ||
public abstract fun autoClose (Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public abstract fun install (Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/AutoCloseScope$DefaultImpls { | ||
public static fun install (Larrow/AutoCloseScope;Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/AutoCloseScopeKt { | ||
public static final fun autoCloseScope (Lkotlin/jvm/functions/Function1;)Ljava/lang/Object; | ||
} | ||
|
||
public final class arrow/AutoCloseableExtensionsKt { | ||
public static final fun install (Larrow/AutoCloseScope;Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/DefaultAutoCloseScope : arrow/AutoCloseScope { | ||
public fun <init> ()V | ||
public fun autoClose (Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function2;)Ljava/lang/Object; | ||
public final fun close (Ljava/lang/Throwable;)Ljava/lang/Void; | ||
public fun install (Ljava/lang/AutoCloseable;)Ljava/lang/AutoCloseable; | ||
} | ||
|
||
public final class arrow/ThrowIfFatalKt { | ||
public static final fun throwIfFatal (Ljava/lang/Throwable;)Ljava/lang/Throwable; | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd like
onClose
better to reflectonRelease
fromResourceScope