Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds GitHub authentication to avoid rate limiting failures. #433

Merged

Conversation

hemanik
Copy link
Member

@hemanik hemanik commented Apr 6, 2018

Short description of what this resolves:

It is common for GitHub API rate limit of 60 requests per hour for an unauthenticated user to be exceeded when multiple generation builds are run in parallel.
Adding authentication significantly extends this restrictive rate limit to 5000 requests per hour.

Changes proposed in this pull request:

  • adds OAuth authentication header taking the token from .github-auth to the GitHub requests.

Fixes: #432

@hemanik hemanik force-pushed the github-authentication branch from 3af8be5 to 8469672 Compare April 6, 2018 06:56
@hemanik hemanik requested a review from MatousJobanek April 10, 2018 10:37
@hemanik hemanik force-pushed the github-authentication branch from 6529b25 to 216b60e Compare April 16, 2018 12:45
@hemanik hemanik force-pushed the github-authentication branch from 7c8bff0 to 81640e2 Compare April 16, 2018 13:10
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @hemanik

@MatousJobanek MatousJobanek merged commit c7136fb into arquillian:functional-tests Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants