-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix missing] module_option mising option #321
Draft
Tearran
wants to merge
37
commits into
main
Choose a base branch
from
module_options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/medium
PR with more then 50 and less then 250 lines
and removed
size/small
PR with less then 50 lines
labels
Dec 12, 2024
Converts the module_option array into a raw flat json. for jq parsing.
JQ ("JSON Query") generates json list of modules
|
github-actions
bot
added
size/large
PR with 250 lines or more
and removed
size/medium
PR with more then 50 and less then 250 lines
labels
Dec 13, 2024
github-actions
bot
added
size/medium
PR with more then 50 and less then 250 lines
and removed
size/large
PR with 250 lines or more
labels
Dec 14, 2024
github-actions
bot
added
size/large
PR with 250 lines or more
and removed
size/medium
PR with more then 50 and less then 250 lines
labels
Dec 14, 2024
4 tasks
- attach to custom docker bridge - add purge option
- attach to custom docker bridge - add purge option
github-actions
bot
added
size/medium
PR with more then 50 and less then 250 lines
Documentation
Documentation changes or additions
and removed
size/large
PR with 250 lines or more
labels
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
Documentation changes or additions
size/medium
PR with more then 50 and less then 250 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea from the start was to have one data entry point, the "Header". The active data array can be viewed with
git repo
orapt installed
using the command:armbian-config --api generate_json_object
This PR is the first step towards producing a JSON object pipeline that will eventually replace the JSON file. By leveraging the already used
module_option
array andjq
for querying, we aim to ensure consistency and eliminate the need to manually edit or source a separate file.Many JSON keys are missing in the
module_option
array and cannot be parsed or queried. Leveragingjq
can:Changes Made
module_option
array for better parsing and querying.generate_json_data.sh
script to properly handle the new keys and generate a valid JSON object.config.runtime.sh
module_options to remove unhandled escape sequences and quotes.Goals and Impact
jq
optimization.Testing
./bin/armbian-config --api set_json_options
produces the correct JSON output.Notes
armbian-config --api generate_json_options
is out of date and needs updating.module_options
array was lacking needed keys, and this PR addresses multiple issues such as loading times and nesting issues that bash is not meant to handle.