Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add independent CPUFREQ config manipulation options #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 6, 2024

Description

Introducing new config /etc/default/armbian-cpufrequtils that is independent from deprecated cpufrequtils. Functionality only manipulate config file, while service needs to be added at buildtime.

Implementation Details

A service that will read /etc/default/armbian-cpufrequtils needs to be added to armbian OS. Functionality should be merged in "Disabled" state.

Testing Procedure

  • Configuration is generated and manipulated correctly

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • No new external dependencies are included
  • Changes have been tested and verified

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Oct 6, 2024
@github-actions github-actions bot added Scripts size/medium PR with more then 50 and less then 250 lines labels Oct 6, 2024
@EvilOlaf
Copy link
Member

EvilOlaf commented Oct 6, 2024

Isn't cpufrequtils considered deprecated?

@igorpecovnik
Copy link
Member Author

Yes. This should be reworked.

@igorpecovnik igorpecovnik force-pushed the add_cpu_freq branch 3 times, most recently from d335b37 to 1d568c4 Compare October 6, 2024 15:16
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Dependencies Pull requests that update a dependency labels Oct 6, 2024
@igorpecovnik igorpecovnik changed the title Add CPUFREQ options Add independent CPUFREQ manipulation options Oct 6, 2024
@igorpecovnik igorpecovnik changed the title Add independent CPUFREQ manipulation options Add independent CPUFREQ config manipulation options Oct 6, 2024
Signed-off-by: Gunjan Gupta <[email protected]>
@igorpecovnik
Copy link
Member Author

Now, we "only" need a replacement service to read those files and set CPU.

@github-actions github-actions bot removed the Scripts label Oct 28, 2024
@igorpecovnik igorpecovnik added 02 Milestone: First quarter release and removed 11 Milestone: Fourth quarter release labels Nov 12, 2024
@dimitry-ishenko dimitry-ishenko deleted the add_cpu_freq branch December 11, 2024 05:32
@dimitry-ishenko dimitry-ishenko restored the add_cpu_freq branch December 11, 2024 06:13
@igorpecovnik igorpecovnik reopened this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Dependencies Pull requests that update a dependency Scripts size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants