fix: rename redirect_url to return_url on ConfirmSetupIntent #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am about to merge a different PR that fixes the ahash pin issue, I'll let you know when you can rebase |
|
@arlyon it seems like ahash reverted the change that made it require a newer version of rustc, so the latest version of ahash should pass CI again. Issue: tkaitchuck/aHash#207 |
augustoccesar
force-pushed
the
fix/correct-return-url-attribute-for-confirming-setup-intent
branch
2 times, most recently
from
c5a8b25 to
c1b8a5c
Compare
### Description As raised on arlyon#504, this attribute have the incorrect name according to the [documentation](https://docs.stripe.com/api/setup_intents/confirm#confirm_setup_intent-return_url). This change renames the field `redirect_url` to `return_url`. closes arlyon#504
augustoccesar
force-pushed
the
fix/correct-return-url-attribute-for-confirming-setup-intent
branch
from
c1b8a5c to
9da5a28
Compare
|
@arlyon now it seems to be all passing 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
As raised on #504, this attribute have the incorrect name according to the documentation. This change renames the field
redirect_urltoreturn_url.closes #504
Checklist
cargo make fmt