fix: update during setWeight: 100 could cause 503 errors

[jessesuen]

Resolves #3372

Testing a possible fix for #3372 submitted to me offline by another user.

E2E test would be needed.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (4e44913) to head (b2cc54b).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   83.88%   83.87%   -0.02%     
==========================================
  Files         163      163              
  Lines       18564    18576      +12     
==========================================
+ Hits        15573    15581       +8     
- Misses       2119     2121       +2     
- Partials      872      874       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 16m 38s ⏱️
113 tests 100 ✅  7 💤 6 ❌
458 runs  424 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit b2cc54b.

[github-actions]

Published Unit Test Results

2 275 tests   2 275 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit b2cc54b.

[zachaller]

This seems to almost be the same fix #3878 should we consolidate to one? Also instead of 100 we should use weightutil.MaxTrafficWeight(c.rollout)

[Abhish2702]

This seems to almost be the same fix #3878 should we consolidate to one? Also instead of 100 we should use weightutil.MaxTrafficWeight(c.rollout)

@zachaller thanks for the suggestion, actually I have raised #3878 along with unit test for the same fix. This PR was raised by @jessesuen for testing purpose only upon my request when I approached him offline with this suggestion. So, yes we can consolidate these PRs