-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for httpcaching of github requests #21309
Draft
aburan28
wants to merge
12
commits into
argoproj:master
Choose a base branch
from
aburan28:adam--httpcache-scm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+133
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Adam Buran <[email protected]> Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]> Signed-off-by: aburan28 <[email protected]>
Signed-off-by: [email protected] <[email protected]> Signed-off-by: aburan28 <[email protected]>
Signed-off-by: [email protected] <[email protected]> Signed-off-by: aburan28 <[email protected]>
Signed-off-by: [email protected] <[email protected]> Signed-off-by: aburan28 <[email protected]>
aburan28
changed the title
feature: add support for httpcaching of github requests
feat: add support for httpcaching of github requests
Dec 24, 2024
Signed-off-by: aburan28 <[email protected]>
aburan28
force-pushed
the
adam--httpcache-scm
branch
from
December 24, 2024 17:41
ccfefd8
to
a2ce309
Compare
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a LRU cache to the applicationset controller. This uses the httpcache library which is a http RoundTripper that caches requests based on etag or last modified.
Additionally this PR makes some minor changes to the github client instantiation in that it removes the dependency on oauth2 for token based auth.
Fixes issue
Checklist: