Skip to content

Commit

Permalink
fix: Change applicationset generate HTTP method to avoid route confli…
Browse files Browse the repository at this point in the history
…cts (#20758) (#21299)

* Change applicationset generate HTTP method to avoid route conflicts



* Update server/applicationset/applicationset.proto




* Codegen



---------

Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Amit Oren <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
  • Loading branch information
3 people authored Dec 23, 2024
1 parent 9014649 commit 0a26e0f
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 44 deletions.
33 changes: 33 additions & 0 deletions assets/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

84 changes: 42 additions & 42 deletions pkg/apiclient/applicationset/applicationset.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apiclient/applicationset/applicationset.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion server/applicationset/applicationset.proto
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ service ApplicationSetService {
// Generate generates
rpc Generate (ApplicationSetGenerateRequest) returns (ApplicationSetGenerateResponse) {
option (google.api.http) = {
post: "/api/v1/applicationsets"
post: "/api/v1/applicationsets/generate"
body: "*"
};
}
Expand Down

0 comments on commit 0a26e0f

Please sign in to comment.