Fix issue in extraCommandArgs field

[Rizwana777]

JIRA - https://issues.redhat.com/browse/GITOPS-5200

[jopit]

I don't see any logic to address the 3rd problem reported in the Jira issue

3. Adding argument and value as a single element causes the pod to crash

Other than that, it looks good to me.

[Rizwana777]

I don't see any logic to address the 3rd problem reported in the Jira issue

3. Adding argument and value as a single element causes the pod to crash

Other than that, it looks good to me.

Thanks John, for 3rd point -

Pod crashes as mentioned in description because ,

'{.spec.server.extraCommandArgs}' ["foo bar"] , here extraCommandArgs is of type []string and we need to pass the flag value i.e, foo as --foo and bar as value like this ["--foo" "bar"] , if we pass values as mentioned pod will not crash, 
and pod crashes as mentioned in description is :
error : Error: unknown flag: --foo
Usage:
argocd-server [flags]
argocd-server [command], as --foo is a flag and we can use available flags

[Rizwana777]

FAIL: kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace this e2e test is failing in other PRs as well

[saumeya]

Re-ran the tests

[Rizwana777]

FAIL: kuttl/harness/1-036_validate_role_rolebinding_for_source_namespace this e2e test is failing in other PRs as well

All the tests are passing now

[svghadi]

@Rizwana777 - Can we allow users to override params? There may be cases where tuning of default params could be useful.

[Rizwana777]

@svghadi I have updated the code which allow the users to override existing params, PTAL

[svghadi]

Based on our Slack discussion, could you try using a map[string]string to simplify the logic?

[Rizwana777]

@svghadi I tried updating the logic to use map[string]string but found issues as mentioned-

• map[string]string creates a map of flags to values, meaning it's expecting each flag to be associated with a value (or an empty string if no value is provided) this approach has the risk of treating arguments like --staticassets as executable commands if there is an issue in the flag parsing. If the function expects this argument to be passed as part of a command and it's incorrectly handled (i.e., not paired with a valid value), this could lead to the error like - create failed: unable to start container process: exec: "--staticassets": executable file not found in $PATH"

• On the other hand, map[string]int keeps track of the exact positions of flags in the original cmd array, so any updates or additions to cmd are carefully done by index. This prevents the accidental misinterpretation of arguments and ensures the correct structure for the final command.

I may be mistaken, but PTAL and let me know your thoughts. I'm open to any suggestions

[jgwest]

In addition, it appears that ExtraRepoCommandArgs, which controls extra repo server args, is missing from this PR.

[jgwest]

I see this PR has similar unit tests for other functions, but can we also add a unit test for this function?

The logic in this function is complex (given the large possible variation in inputs), so I'd like to ensure we have an exhaustive list of test cases that verify the possible cases we can think of that this function might be asked to handle.