code-refactoring: Gitops 3127 implement applicationset controller package #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cai <[email protected]>
…-3127-implement-applicationset-controller-package
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
…-3127-implement-applicationset-controller-package
Signed-off-by: Yi Cai <[email protected]>
jaideepr97
reviewed
Oct 2, 2023
jaideepr97
reviewed
Oct 2, 2023
jaideepr97
reviewed
Oct 2, 2023
jaideepr97
reviewed
Oct 2, 2023
jaideepr97
reviewed
Oct 2, 2023
|
@ciiay if all the old code has been accounted for, please remove those files |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
jaideepr97
reviewed
Oct 3, 2023
|
@ciiay Appset Also has a webhookserver route that needs to be reconciled by the appset controller |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
…econcile Signed-off-by: Yi Cai <[email protected]>
…-3127-implement-applicationset-controller-package
Signed-off-by: Yi Cai <[email protected]>
jaideepr97
approved these changes
Oct 5, 2023
jaideepr97
merged commit 7607d97
into
argoproj-labs:operator-redesign
1 of 3 checks passed
Julik24
pushed a commit
to Julik24/argocd-operator
that referenced
this pull request
Apr 24, 2024
…kage (argoproj-labs#1011) *add appset-controller --------- Signed-off-by: Yi Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does this PR do / why we need it:
Implemented notifications controller.
NOTE: this PR just adds the package files and tests, this code is not invoked at any point yet
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
GITOPS-3127: https://issues.redhat.com/browse/GITOPS-3127
How to test changes / Special notes to the reviewer:
Unit tests and kuttl tests uploaded.