Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swift-transformers to 0.1.12 #249

Closed
wants to merge 3 commits into from

Conversation

BrandonWeng
Copy link

Ran into issues while trying to use MLX models locally. mlx-community/Llama-3.2-1B-Instruct-bf16 seems to require the Sequence post processor. https://github.com/huggingface/swift-transformers/blob/main/Sources/Tokenizers/PostProcessor.swift#L42

MLX is still relatively new, so the package bump might not be warranted as it does introduce jinja as a dependency (guessing its because of the chat template). I will leave this here for posterity and in case other folks run into this issue

@ZachNagengast
Copy link
Contributor

@BrandonWeng Are you testing on the MLX branch in this repo? I'd be ok with merging this into that branch in the meantime to unblock you, still need to assess the impact of upgrading before merging with main.

@BrandonWeng
Copy link
Author

No, I'm rooting for ya'll to get MLX working in this repo. (#200)

Lets just close this for now, I can maintain my fork with this repo in the meantime. Its not a blocker for us

@BrandonWeng BrandonWeng closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants