Merge pull request #229 from arethetypeswrong/bug/224

Fix named exports check crash when resolution is JS-only
arethetypeswrong · Dec 6, 2024 · b9cf960 · b9cf960
2 parents c09df85 + def786e
commit b9cf960
Show file tree

Hide file tree

Showing 4 changed files with 795 additions and 1 deletion.
diff --git a/.changeset/dry-jokes-accept.md b/.changeset/dry-jokes-accept.md
@@ -0,0 +1,5 @@
+---
+"@arethetypeswrong/core": patch
+---
+
+Fix named exports check crash when resolution is JS-only
diff --git a/packages/core/src/internal/checks/namedExports.ts b/packages/core/src/internal/checks/namedExports.ts
@@ -7,7 +7,7 @@ export default defineCheck({
   name: "NamedExports",
   dependencies: ({ entrypoints, subpath, resolutionKind, programInfo }) => {
     const entrypoint = entrypoints[subpath].resolutions[resolutionKind];
-    const typesFileName = entrypoint.resolution?.fileName;
+    const typesFileName = entrypoint.resolution?.isTypeScript && entrypoint.resolution.fileName;
     const resolutionOption = getResolutionOption(resolutionKind);
     const typesModuleKind = typesFileName ? programInfo[resolutionOption].moduleKinds?.[typesFileName] : undefined;
     const implementationFileName = entrypoint.implementationResolution?.fileName;

diff --git a/packages/core/test/fixtures/[email protected] b/packages/core/test/fixtures/[email protected]