fix: correct exit code for ignored resolutions

arethetypeswrong · Sep 20, 2024 · 65d3064 · 65d3064
1 parent e7ac94c
commit 65d3064
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/cli/src/getExitCode.ts b/packages/cli/src/getExitCode.ts
@@ -6,8 +6,11 @@ export function getExitCode(analysis: CheckResult, opts?: RenderOptions): number
   if (!analysis.types) {
     return 0;
   }
-  if (!opts?.ignoreRules) {
-    return analysis.problems.length > 0 ? 1 : 0;
-  }
-  return analysis.problems.some((problem) => !opts.ignoreRules!.includes(problemFlags[problem.kind])) ? 1 : 0;
+  const ignoreRules = opts?.ignoreRules ?? [];
+  const ignoreResolutions = opts?.ignoreResolutions ?? [];
+  return analysis.problems.some((problem) => {
+    const notRuleIgnored = !ignoreRules.includes(problemFlags[problem.kind]);
+    const notResolutionIgnored = "resolutionKind" in problem ? !ignoreResolutions.includes(problem.resolutionKind) : true;
+    return notRuleIgnored && notResolutionIgnored;
+  }) ? 1 : 0;
 }