Adds support for Keyboard LED (Caps Lock, Scroll Lock, Num Lock) #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@facchinm please would you consider for merge? (This change is a dependency for a related pull request I'm about to add to the keyboard library, adding support for caps lock, scroll lock, num lock leds). |
|
Memory usage change @ dcdb012
Click for full report table
Click for full report CSV |
This was referenced Dec 26, 2021
|
@facchinm please see also ... which has dependencies on this code to add LED status handling to the Keyboard API. thanks |
Callback function avoids the need to poll for status changes.
Avoids the need to continuously poll for changes to caps lock scroll lock num lock
|
Also added a callback feature on LED status reports from the host, so to avoid continuously polling the API to discover if an LED has changed state. Requires programmer to set the callback function as follows; void setup() {
HID().setKeyboardLedsStatusReportCallback( keyboardLedsStatusReportCallback );
}
void loop() {
}
void keyboardLedsStatusReportCallback()
{
// code to set LEDs, respond to caps lock status change, etc etc
} |
|
Thanks @PJ789! Don't worry about these CI failures: That error is unrelated to the changes you propose here in your pull request. I have been seeing transient GitHub Actions workflow run failures all day across many repositories and I suspect this is another. One of the repository maintainers can re-run the failing workflow once GitHub gets back to a working state. |
|
Memory usage change @ 61ea246
Click for full report table
Click for full report CSV |
|
@per1234 that's good to hear. I'm using the code on a current HID keyboard project, where it compiles without issue (Leonardo/SS Micro board), and works well. I'd be delighted to see the capability shared with other developers. |
facchinm
requested changes
Jan 11, 2022
| @@ -133,25 +133,48 @@ bool HID_::setup(USBSetup& setup) | |||
| } | |||
| if (request == HID_SET_REPORT) | |||
There was a problem hiding this comment.
Is keyboard LEDs the only time this kind of request is being actively used? I'd prefer to add some more generic API as in PluggableUSB framework
|
The best thing to do, IMO, would be to create a new PluggableHID API where a derived module can register its function (or it's ignored otherwise). Any chance you can try this approach? |
|
Memory usage change @ fd8d12d
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code here, adapted very slightly to improve legibility;-
https://forum.arduino.cc/t/leonardo-keyboard-leds-emulation/169582/23