-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose card and volume objects allowing for interface to tinyUSB #116
Open
rrainey
wants to merge
2
commits into
arduino-libraries:master
Choose a base branch
from
rrainey:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Apr 17, 2022
Memory usage change @ 31c69c2
Click for full report table
Click for full report CSV
|
Any prospect of having this merged? |
Memory usage change @ 8cc66dc
Click for full report table
Click for full report CSV
|
I recently updated my fork to catch up with the head of the current SD master. Is there any prospect for getting this PR merged? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change exposes references to the card and volume objects in SDClass.
This allows for a deeper integration with Arduino's TinyUSB disk interface that would not normally be possible. See the Adafruit TinyUSB Library Examples > Mass Storage > msc_sd source code. By exposing the card and volume objects, one can re-express this interface using core SDClass as the interface point -- instead of resorting to separate card and volume instances as is shown in this example. This makes it possible to have concurrent file-level interactions in the Arduino code while exposing the SD card to a host via the TinyUSB disk interface.