Add helpful tips for saving config files in a directory #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svartkanin
requested changes
Nov 15, 2024
| @@ -148,7 +148,15 @@ def preview(selection: str) -> Optional[str]: | |||
| while True: | |||
| path = input( | |||
| _( | |||
| "Enter a directory for the configuration(s) to be saved (tab completion enabled)\nSave directory: " | |||
| '''\ | |||
| Into which DIRECTORY should the configuration(s) be saved? | |||
There was a problem hiding this comment.
this is goind to output every time someone presses which is quite annoying
I would be better to show this output only once on the top
|
Maybe we could mention that the current installation is mounted under Or simply: And then put it somewhere safe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The first few times I used archinstall, I struggled with saving config files to a directory. It sounds easy, I know. But at the time I kept getting errors and finally gave up saving any config files at all.
This PR makes it obvious why tab-completion is a boon in this scenario. It also gives a couple useful working locations, and it clarifies that extra steps are needed if you want your config files to persist through a boot cycle.
Here is a screenshot showing the updated text:
Tests and Checks