Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new curses menu #2663

Merged
merged 60 commits into from
Nov 15, 2024
Merged

Conversation

svartkanin
Copy link
Collaborator

@svartkanin svartkanin commented Aug 31, 2024

Integrate the new curses menu into archinstall and replace all 3rd party menu usages with the custom curses implementation.

Screencast_20240831_112628.mp4
  • Replace all existing simple-term-menu usages with custom curses implementation
  • Add preset value for text inputs
  • Test all menu options for preview and preset values
  • Replace all print statements with either debug or custom curses print

@svartkanin svartkanin marked this pull request as ready for review October 12, 2024 09:57
@svartkanin svartkanin requested a review from Torxed as a code owner October 12, 2024 09:57
@svartkanin
Copy link
Collaborator Author

svartkanin commented Oct 12, 2024

@Torxed I think this is now ready for a full review. Only thing left is fixing the swiss.py script

@svartkanin
Copy link
Collaborator Author

swiss.py script has also been adapted now

@Torxed
Copy link
Member

Torxed commented Nov 9, 2024

Running a few last tests, and I can't tell if it's the code in master yet or this PR, but #2793 is blocking a release.

I'm running out of time for more tests for today.
I'll continue tomorrow unless you have a moment to double check @svartkanin?

Copy link
Member

@Torxed Torxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I'll rerun a few tests against master with the disk issue but other then that let's get a new version out!

@Torxed Torxed merged commit 88b91ae into archlinux:master Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants