Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various mypy errors in archinstall/lib/ #2640

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

correctmost
Copy link
Contributor

PR Description:

This PR fixes various mypy errors in archinstall/lib/. The remaining errors are more complex and can be handled separately.

Tests and Checks

  • I have tested the code!

@correctmost correctmost requested a review from Torxed as a code owner August 27, 2024 15:31
@svartkanin
Copy link
Collaborator

@correctmost do you mind adding any files/directories that are fully fixed to the mypy.ini file as includes, that way they are ensured to remain clean as the check is run on PRs

@svartkanin svartkanin merged commit c7aeead into archlinux:master Aug 27, 2024
6 checks passed
@correctmost correctmost deleted the cm/mypy-lib branch August 27, 2024 19:46
@correctmost
Copy link
Contributor Author

@correctmost do you mind adding any files/directories that are fully fixed to the mypy.ini file as includes, that way they are ensured to remain clean as the check is run on PRs

I have an upcoming PR that will expand the mypy checks in pyproject.toml. I'm hoping it will be possible to remove mypy.ini soon.

Thanks for the reviews!

@svartkanin
Copy link
Collaborator

@correctmost the mypy.ini that currently exists is an addition to the config in the toml as it's basically strictly checking everything. Not sure the toml can be removed or replaced before all files are compliant with the strict validation

@Torxed
Copy link
Member

Torxed commented Aug 28, 2024

I think we'll need it until the entire project is compliant.
Which might take a while, but we really appreciate the contributions to get close to that goal.
It will speed up error checks a lot once the coverage is complete.

@correctmost
Copy link
Contributor Author

I think I found a good way to centralize the mypy configs and increase strictness: #2651

This will allow us to gradually roll out more strict checks over the entire codebase without dealing with multiple config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants