Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SysCommand decoding #2121

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Simplify SysCommand decoding #2121

merged 5 commits into from
Oct 2, 2023

Conversation

svartkanin
Copy link
Collaborator

This simplifies the return of SysCommand a bit

  • decode will use utf-8 as a default arg
  • split is always performed on decode but can be disabled via an arg

@svartkanin svartkanin requested a review from Torxed as a code owner September 27, 2023 11:34
Torxed
Torxed approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@Torxed Torxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the improvements, we have to tripe-check all the logic using SysCommand* to make sure we don't hit any snags. But good work!

@svartkanin svartkanin merged commit 5c903df into archlinux:master Oct 2, 2023
6 checks passed
@svartkanin svartkanin deleted the update-syscommand branch October 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefiles codefiles codefiles left review comments

@Torxed Torxed Torxed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svartkanin @Torxed @codefiles