Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixin remapping quirk #172

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Fix mixin remapping quirk #172

merged 1 commit into from
Dec 31, 2021

Conversation

magneticflux-
Copy link
Contributor

Closes #170

@magneticflux- magneticflux- marked this pull request as ready for review December 31, 2021 03:59
@magneticflux-
Copy link
Contributor Author

I opened an issue about this behavior here: SpongePowered/Mixin#551
Hopefully this quirk is documented for the future so this doesn't happen again!

@magneticflux- magneticflux- changed the title Fix mixin typo Fix mixin remapping quirk Dec 31, 2021
@ztgasdf
Copy link

ztgasdf commented Dec 31, 2021

latest.log
works! doesn't crash anymore

@shedaniel shedaniel added bug Something isn't working priority: high This needs to be worked on and reviewed ASAP labels Dec 31, 2021
@shedaniel shedaniel merged commit b61045b into architectury:1.18 Dec 31, 2021
MaxNeedsSnacks added a commit that referenced this pull request Dec 31, 2021
@MaxNeedsSnacks
Backport of #154 and #172 to 1.17
4b468a2 
Contains the following changes:
- Explicitly add `remap=true` to fix mixin failing in prod (#172)
- @reDIrect workaround for closing #152 (#154)

Co-authored-by: shedaniel <[email protected]>
Co-authored-by: Mitchell Skaggs <[email protected]>

Signed-off-by: Max <[email protected]>
MaxNeedsSnacks added a commit that referenced this pull request Dec 31, 2021
@MaxNeedsSnacks
Backport of #154 and #172 to 1.16
c68a637 
Contains the following changes:
- Explicitly add `remap=true` to fix mixin failing in prod (#172)
- @reDIrect workaround for closing #152 (#154)

Co-authored-by: shedaniel <[email protected]>
Co-authored-by: Mitchell Skaggs <[email protected]>

Signed-off-by: Max <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shedaniel shedaniel shedaniel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: high This needs to be worked on and reviewed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.18.1] Architectury crashes on start
3 participants
@magneticflux- @ztgasdf @shedaniel