Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add permissioned signer functionality #14521

Open
wants to merge 1 commit into
base: 08-29-create_permissioned_signer_example
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Sep 4, 2024

Description

Implement rust extension for the permissioned signer, including the new ser/de logic.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

This will be tested with future PRs. Also a replay-verify is executed to make sure this feature is not breaking.

Key Areas to Review

We still need to keep the old serialization logic in the bcs module because it can otherwise cause on chain divergence.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 4, 2024

⏱️ 3h 20m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 19m 🟩
rust-move-unit-coverage 18m 🟩
rust-cargo-deny 15m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 14m 🟩
general-lints 14m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 14m 🟩
rust-move-unit-coverage 11m 🟩
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 8m 🟥
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 7m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 85.80247% with 23 lines in your changes missing coverage. Please review.

Project coverage is 60.1%. Comparing base (e7391d6) to head (7c5a356).

Files with missing lines Patch % Lines
...party/move/move-vm/types/src/values/values_impl.rs 75.0% 13 Missing ⚠️
...-move/framework/src/natives/permissioned_signer.rs 94.2% 3 Missing ⚠️
...rd_party/move/move-compiler-v2/src/plan_builder.rs 50.0% 3 Missing ⚠️
third_party/move/move-vm/types/src/value_serde.rs 40.0% 3 Missing ⚠️
third_party/move/move-core/types/src/value.rs 92.8% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           08-29-create_permissioned_signer_example   #14521    +/-   ##
==========================================================================
  Coverage                                      60.1%    60.1%            
==========================================================================
  Files                                           856      857     +1     
  Lines                                        211026   210762   -264     
==========================================================================
- Hits                                         126865   126723   -142     
+ Misses                                        84161    84039   -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 456f5f4 to 55771fc Compare September 4, 2024 20:29
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 31c9b2c to 6d309ff Compare September 4, 2024 20:30
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 55771fc to 070a951 Compare September 5, 2024 00:41
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6d309ff to 703921b Compare September 5, 2024 00:41
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 070a951 to b832d3d Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 703921b to 48991ff Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from b832d3d to 6ddb481 Compare September 9, 2024 07:46
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 48991ff to 906c7c7 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 6ddb481 to 8b92b98 Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 906c7c7 to 350db4c Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 8b92b98 to fa646c8 Compare September 10, 2024 17:24
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from fa646c8 to c3aba3a Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from c3aba3a to 50b556b Compare September 12, 2024 01:49
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50
@runtian-zhou runtian-zhou mentioned this pull request Sep 12, 2024
21 tasks
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 50b556b to 8cd68d5 Compare September 17, 2024 05:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08
@lightmark lightmark changed the title Implement rust logics for permissioned signer [feature] Add permissioned signer functionality Sep 17, 2024
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 3 times, most recently from 1835d3d to 42decc7 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 7b40933 to 246b08a Compare November 27, 2024 03:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 6 times, most recently from 2a56afe to bde993b Compare November 27, 2024 08:39
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 246b08a to 1a9a7ec Compare December 2, 2024 02:39
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from bde993b to 415d5c2 Compare December 2, 2024 02:39
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 1a9a7ec to f202c5e Compare December 2, 2024 02:42
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 415d5c2 to e0409cc Compare December 2, 2024 02:43
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from f202c5e to bcf98d8 Compare December 2, 2024 10:04
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 3 times, most recently from 0f881a5 to 1302971 Compare December 5, 2024 02:22
@runtian-zhou runtian-zhou marked this pull request as ready for review December 14, 2024 15:27
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from bcf98d8 to 93706d9 Compare December 14, 2024 17:59
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1302971 to 4505dc2 Compare December 14, 2024 17:59
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 93706d9 to cad586d Compare December 16, 2024 16:35
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 4505dc2 to 2dfa163 Compare December 16, 2024 16:35
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from cad586d to 59309c6 Compare December 17, 2024 02:26
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 2dfa163 to 7b93a7d Compare December 17, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants