-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add permissioned signer functionality #14521
base: 08-29-create_permissioned_signer_example
Are you sure you want to change the base?
[feature] Add permissioned signer functionality #14521
Conversation
⏱️ 3h 20m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 08-29-create_permissioned_signer_example #14521 +/- ##
==========================================================================
Coverage 60.1% 60.1%
==========================================================================
Files 856 857 +1
Lines 211026 210762 -264
==========================================================================
- Hits 126865 126723 -142
+ Misses 84161 84039 -122 ☔ View full report in Codecov by Sentry. |
456f5f4
to
55771fc
Compare
31c9b2c
to
6d309ff
Compare
55771fc
to
070a951
Compare
6d309ff
to
703921b
Compare
070a951
to
b832d3d
Compare
703921b
to
48991ff
Compare
b832d3d
to
6ddb481
Compare
48991ff
to
906c7c7
Compare
6ddb481
to
8b92b98
Compare
906c7c7
to
350db4c
Compare
8b92b98
to
fa646c8
Compare
350db4c
to
dad258f
Compare
fa646c8
to
c3aba3a
Compare
dad258f
to
6b4da66
Compare
c3aba3a
to
50b556b
Compare
6b4da66
to
b1fd015
Compare
50b556b
to
8cd68d5
Compare
b1fd015
to
6592c01
Compare
1835d3d
to
42decc7
Compare
7b40933
to
246b08a
Compare
2a56afe
to
bde993b
Compare
246b08a
to
1a9a7ec
Compare
bde993b
to
415d5c2
Compare
1a9a7ec
to
f202c5e
Compare
415d5c2
to
e0409cc
Compare
f202c5e
to
bcf98d8
Compare
0f881a5
to
1302971
Compare
bcf98d8
to
93706d9
Compare
1302971
to
4505dc2
Compare
93706d9
to
cad586d
Compare
4505dc2
to
2dfa163
Compare
cad586d
to
59309c6
Compare
2dfa163
to
7b93a7d
Compare
Description
Implement rust extension for the permissioned signer, including the new ser/de logic.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
This will be tested with future PRs. Also a replay-verify is executed to make sure this feature is not breaking.
Key Areas to Review
We still need to keep the old serialization logic in the bcs module because it can otherwise cause on chain divergence.
Checklist