-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ClientBootstrap reuse is not important but permissible on the same thread/EL #2520
base: main
Are you sure you want to change the base?
Conversation
@tayloraswift I needed to undo the ``Sendable`` and ``EventLoop`` because they're in different modules :|
it would be really great if we could suppress the DocC symbol link warnings, those cross-module/cross-package links work on Swiftinit! |
@franklinsch is this an option? Or will this work in DocC soon too? Context is that I had to take out
and
because it complained |
@weissi We're tracking cross-target link resolution with swiftlang/swift-docc#208. It's being worked on primarily by @d-ronnqvist |
The initial support for cross-target linking in DocC is available on main behind a feature flag but the overall feature of multi-target documentation is still in progress. Note that the planned—and currently implemented—syntax for linking to a symbol in another module is
stating with a leading
|
@dnadoba I assume NIO isn't using feature flags for its docs right now so this has to stay as is, correct? |
I'm not aware of any feature flags set for DocC in NIO. The two main way DocC is compiled is through the build system provided by https://swiftpackageindex.com/ and Xcodes "Product -> Build Documentation" action. I'm not aware of a safe way to add flags to both of them. |
do these links actually produce any build errors in Xcode? |
Motivation:
The original
ClientBootstrap
documentation is sometimes misunderstood as stressing the importance to re-use.Modifications:
Explain that reuse is not important but permissible on the same thread/EL.
Result:
Clearer docs.